-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(participants-pane) consolidate moeration options #11891
base: master
Are you sure you want to change the base?
Conversation
They are now under a single "Moderator" button.
I'm not sure what to do about the config options to hide these buttons. Should we rename it to say "hideModeratorButton" ? Does anyone see the need for having individual hiding options if they are under the same menu? I'd say no... |
Apologies for butting in. Not sure how common a use case this is, but in our setup most of our users get moderator privileges and the "Allow attendees to:" actions sometimes cause confusion because others can still unmute themselves and enable video (because they are also moderator). Given a choice, I would enable the "Mute all" and "Stop everyone's video" options but hide the other AV moderation actions to avoid confusion. But not a big deal if it's all or nothing. |
The web part LGTM. I'll leave the native to Calin |
Thanks for the feedback! Do you think changing the text would help? Something like "Allow non-moderators to: ..." |
Changing to something like "Allow non-moderators to: ..." would certainly help! 👍 |
I agree that |
I agree. Now, in terms of backwards compatibility, how would you translate the old options into the new one? |
Let's enforce the interfaceConfig.SETTINGS_SECTIONS in the cases where we get opposite values and see whether it's relevant to keep the |
Native part LGTM. |
Thanks! I'll add the backwards compat bits before merge. |
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please fix conflicts, if this is ready for review. Thanks! |
They are now under a single "Moderator" button.